models: break out of loops#12159
Merged
Merged
Conversation
techknowlogick
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 1
Contributor
|
will an empty case not result in the same result but not require a goto and lable? |
Contributor
Contributor
|
the error came from when during a failed refactor attempt I tried to move this out to a method that returned directly - but didn't I unwind the refactor completely |
Member
|
Maybe break could be replaced with |
lunny
approved these changes
Jul 6, 2020
GiteaBot
added
lgtm/done
Contributor
|
make lgtm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three spots in the
modelspackage where abreakwas being called from aswitchthat was inside aforloop, turning it into a no-op. This labels the outer loop so thebreakwill make it out of both theforand theswitch.